linux-kernel - Re: [PATCH 11/13] dt-bindings: a2b: add compatible string for Beosound Shape node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d311fd3-8d07-40df-bc91-e4df522efb99@kernel.org>
Date: Sun, 19 May 2024 13:41:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alvin Šipraga <alvin@...s.dk>,
 Mark Brown <broonie@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Liam Girdwood <lgirdwood@...il.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>
Cc: Emil Svendsen <emas@...g-olufsen.dk>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-sound@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-i2c@...r.kernel.org, Alvin Šipraga
 <alsi@...g-olufsen.dk>
Subject: Re: [PATCH 11/13] dt-bindings: a2b: add compatible string for
 Beosound Shape node

On 17/05/2024 15:02, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@...g-olufsen.dk>
> 
> The Beosound Shape has the same device tree bindings as an AD2425, so it
> is sufficient to just add an entry to the compatible enum.

? If it has the same, then devices are compatible but your binding did
not express it.

> 
> Signed-off-by: Alvin Šipraga <alsi@...g-olufsen.dk>
> ---
>  Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml b/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> index dcda15e8032a..bea29f88d535 100644
> --- a/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> +++ b/Documentation/devicetree/bindings/a2b/adi,ad24xx.yaml
> @@ -81,6 +81,7 @@ patternProperties:
>            - adi,ad2427-node
>            - adi,ad2428-node
>            - adi,ad2429-node
> +          - beo,shape-node

You just added this binding. Add entire binding in one patch.

Best regards,
Krzysztof