linux-kernel - Re: [PATCH] platform/x86: ISST: fix use after free problem in tpmi_sst_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 20 May 2024 10:53:35 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Su Hui <suhui@...china.com>, srinivas.pandruvada@...ux.intel.com,
        hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, nathan@...nel.org,
        ndesaulniers@...gle.com, morbo@...gle.com, justinstitt@...gle.com
Cc: rui.zhang@...el.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] platform/x86: ISST: fix use after free problem in
 tpmi_sst_dev_remove()

Hi Su Hui,

On 20/05/24 07:49, Su Hui wrote:
> clang static checker (scan-build) warning:
> drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c:1614:24:
> Use of memory after it is freed.
> 
> Using 'tpmi_sst->package_id' after releasing 'tpmi_sst' causes this
> problem. Change the order of releasing 'tpmi_sst' to fix this.
> 

This is fixed by me already.
Ref: 
https://lore.kernel.org/all/9293c51c7d502843bfff90c5664be00bfe112e8d.camel@linux.intel.com/

Thanks,
Harshit
> Fixes: 9d1d36268f3d ("platform/x86: ISST: Support partitioned systems")
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
>   drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> index 7bac7841ff0a..7fa360073f6e 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> @@ -1610,8 +1610,8 @@ void tpmi_sst_dev_remove(struct auxiliary_device *auxdev)
>   	tpmi_sst->partition_mask_current &= ~BIT(plat_info->partition);
>   	/* Free the package instance when the all partitions are removed */
>   	if (!tpmi_sst->partition_mask_current) {
> -		kfree(tpmi_sst);
>   		isst_common.sst_inst[tpmi_sst->package_id] = NULL;
> +		kfree(tpmi_sst);
>   	}
>   	mutex_unlock(&isst_tpmi_dev_lock);
>   }