[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c05f91f5-a878-4f36-b325-0ac8e038a7e5@linaro.org>
Date: Mon, 20 May 2024 09:09:04 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kartik Agarwala <agarwala.kartik@...il.com>, lgirdwood@...il.com,
broonie@...nel.org, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] ASoC: dt-bindings: mt6358: Convert to dtschema
On 18/05/2024 10:16, Kartik Agarwala wrote:
> Convert Mediatek MT6358 Audio Codec bindings from text to dtschema.
>
> Signed-off-by: Kartik Agarwala <agarwala.kartik@...il.com>
> ---
> .../bindings/sound/mediatek,mt6358.yaml | 47 +++++++++++++++++++
> .../devicetree/bindings/sound/mt6358.txt | 26 ----------
> 2 files changed, 47 insertions(+), 26 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt6358.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/mt6358.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt6358.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt6358.yaml
> new file mode 100644
> index 000000000..f57ef2aa5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt6358.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mediatek,mt6358.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek MT6358 Audio Codec
> +
> +maintainers:
> + - Kartik Agarwala <agarwala.kartik@...il.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The communication between MT6358 and SoC is through Mediatek PMIC wrapper.
> + For more detail, please visit Mediatek PMIC wrapper documentation.
> + Must be a child node of PMIC wrapper.
Did you update the PMIC wrapper binding with ref to this?
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt6358-sound
> + - mediatek,mt6366-sound
You did not test the DTS.
I think I raised the issue already: please make necessary fixes to the
binding (with explanation) or to the DTS, when converting the binding.
> +
> + Avdd-supply:
> + description: power source of AVDD
> +
> + mediatek,dmic-mode:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
Do not need '|' unless you need to preserve formatting.
> + Indicates how many data pins are used to transmit two channels of PDM
> + signal. 0 means two wires, 1 means one wire. Default value is 0.
> + enum:
> + - 0 # one wire
> + - 1 # two wires
> +
> +required:
> + - compatible
> + - Avdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mt6358_snd {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Definitely no underscores. Probably this is "codec" or "audio-codec".
Best regards,
Krzysztof
Powered by blists - more mailing lists