[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <af4b9591-d82e-4da3-b681-eb677369ced3@linux.alibaba.com>
Date: Mon, 20 May 2024 15:40:47 +0800
From: Jingbo Xu <jefflexu@...ux.alibaba.com>
To: libaokun@...weicloud.com, netfs@...ts.linux.dev, dhowells@...hat.com,
jlayton@...nel.org
Cc: hsiangkao@...ux.alibaba.com, zhujia.zj@...edance.com,
linux-erofs@...ts.ozlabs.org, linux-fsdevel@...r.kernel.org,
linux-kernel@...r.kernel.org, yangerkun@...wei.com, houtao1@...wei.com,
yukuai3@...wei.com, wozizhi@...wei.com, Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH v2 05/12] cachefiles: add output string to
cachefiles_obj_[get|put]_ondemand_fd
On 5/15/24 4:45 PM, libaokun@...weicloud.com wrote:
> From: Baokun Li <libaokun1@...wei.com>
>
> This lets us see the correct trace output.
>
> Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
> Signed-off-by: Baokun Li <libaokun1@...wei.com>
Could we move this simple fix to the beginning of the patch set?
Reviewed-by: Jingbo Xu <jefflexu@...ux.alibaba.com>
> ---
> include/trace/events/cachefiles.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/trace/events/cachefiles.h b/include/trace/events/cachefiles.h
> index 119a823fb5a0..bb56e3104b12 100644
> --- a/include/trace/events/cachefiles.h
> +++ b/include/trace/events/cachefiles.h
> @@ -130,6 +130,8 @@ enum cachefiles_error_trace {
> EM(cachefiles_obj_see_lookup_failed, "SEE lookup_failed") \
> EM(cachefiles_obj_see_withdraw_cookie, "SEE withdraw_cookie") \
> EM(cachefiles_obj_see_withdrawal, "SEE withdrawal") \
> + EM(cachefiles_obj_get_ondemand_fd, "GET ondemand_fd") \
> + EM(cachefiles_obj_put_ondemand_fd, "PUT ondemand_fd") \
> EM(cachefiles_obj_get_read_req, "GET read_req") \
> E_(cachefiles_obj_put_read_req, "PUT read_req")
>
--
Thanks,
Jingbo
Powered by blists - more mailing lists