linux-kernel - Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 20 May 2024 15:09:44 +0530
From: Kanak Shilledar <kanakshilledar@...il.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: linux-riscv@...ts.infradead.org, 
	Kanak Shilledar <kanakshilledar111@...tonmail.com>, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, Palmer Dabbelt <palmer@...belt.com>, 
	Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Albert Ou <aou@...s.berkeley.edu>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [PATCH 2/2] dt-bindings: riscv: cpus: add ref to interrupt-controller

On Mon, May 20, 2024 at 1:02 AM Rob Herring (Arm) <robh@...nel.org> wrote:
>
>
> On Sun, 19 May 2024 23:29:06 +0530, Kanak Shilledar wrote:
> > removed the redundant properties for interrupt-controller
> > and provide reference to the riscv,cpu-intc.yaml which defines
> > the interrupt-controller. making the properties for riscv
> > interrupt-controller at a central place.
> >
> > Signed-off-by: Kanak Shilledar <kanakshilledar111@...tonmail.com>
> > ---
> >  .../devicetree/bindings/riscv/cpus.yaml       | 22 +------------------
> >  1 file changed, 1 insertion(+), 21 deletions(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/riscv/cpus.yaml: properties:interrupt-controller: 'oneOf' conditional failed, one must be fixed:
>         Additional properties are not allowed ('$ref' was unexpected)
>         'type' is a required property
>                 hint: DT nodes ("object" type in schemas) can only use a subset of json-schema keywords
>         from schema $id: http://devicetree.org/meta-schemas/interrupts.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240519175906.138410-3-kanakshilledar111@protonmail.com

I have fixed the above warning.

> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.

Can you please clarify this part? Is my base commit ID incorrect?
I am currently using the 6.9.0-rc3 kernel version form
https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/ repo.

Thanks and Regards,
Kanak Shilledar