linux-kernel - Re: [PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM DAI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08b60894-0023-4ad7-9c6b-b1e99b1b4cd8@collabora.com>
Date: Mon, 20 May 2024 12:28:25 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Alexandre Mergnat <amergnat@...libre.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Lee Jones <lee@...nel.org>,
 Flora Fu <flora.fu@...iatek.com>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Sumit Semwal <sumit.semwal@...aro.org>,
 Christian König <christian.koenig@....com>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH v4 09/16] ASoC: mediatek: mt8365: Add PCM DAI support

Il 26/04/24 19:22, Alexandre Mergnat ha scritto:
> Add Pulse Code Modulation Device Audio Interface support for MT8365 SoC.
> 
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
>   sound/soc/mediatek/mt8365/mt8365-dai-pcm.c | 293 +++++++++++++++++++++++++++++
>   1 file changed, 293 insertions(+)
> 
> diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-pcm.c b/sound/soc/mediatek/mt8365/mt8365-dai-pcm.c
> new file mode 100644
> index 000000000000..a5de47c69620
> --- /dev/null
> +++ b/sound/soc/mediatek/mt8365/mt8365-dai-pcm.c
> @@ -0,0 +1,293 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Mediatek 8365 ALSA SoC Audio DAI PCM Control
> + *
> + * Copyright (c) 2024 MediaTek Inc.
> + * Authors: Jia Zeng <jia.zeng@...iatek.com>
> + *          Alexandre Mergnat <amergnat@...libre.com>
> + */
> +
> +#include <linux/bitops.h>
> +#include <linux/regmap.h>
> +#include <sound/pcm_params.h>
> +#include "mt8365-afe-clk.h"
> +#include "mt8365-afe-common.h"
> +
> +struct mt8365_pcm_intf_data {
> +	bool slave_mode;
> +	bool lrck_inv;
> +	bool bck_inv;
> +	unsigned int format;
> +};
> +
> +/* DAI Drivers */
> +
> +static void mt8365_dai_enable_pcm1(struct mtk_base_afe *afe)
> +{
> +	regmap_update_bits(afe->regmap, PCM_INTF_CON1,
> +			   PCM_INTF_CON1_EN, PCM_INTF_CON1_EN);
> +}
> +
> +static void mt8365_dai_disable_pcm1(struct mtk_base_afe *afe)
> +{
> +	regmap_update_bits(afe->regmap, PCM_INTF_CON1,
> +			   PCM_INTF_CON1_EN, 0x0);
> +}
> +
> +static int mt8365_dai_configure_pcm1(struct snd_pcm_substream *substream,
> +				     struct snd_soc_dai *dai)
> +{
> +	struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai);
> +	struct mt8365_afe_private *afe_priv = afe->platform_priv;
> +	struct mt8365_pcm_intf_data *pcm_priv = afe_priv->dai_priv[MT8365_AFE_IO_PCM1];
> +	bool slave_mode = pcm_priv->slave_mode;
> +	bool lrck_inv = pcm_priv->lrck_inv;
> +	bool bck_inv = pcm_priv->bck_inv;
> +	unsigned int fmt = pcm_priv->format;
> +	unsigned int bit_width = dai->sample_bits;
> +	unsigned int val = 0;
> +
> +	if (!slave_mode) {
> +		val |= PCM_INTF_CON1_MASTER_MODE |
> +		       PCM_INTF_CON1_BYPASS_ASRC;
> +
> +		if (lrck_inv)
> +			val |= PCM_INTF_CON1_SYNC_OUT_INV;
> +		if (bck_inv)
> +			val |= PCM_INTF_CON1_BCLK_OUT_INV;
> +	} else {
> +		val |= PCM_INTF_CON1_SLAVE_MODE;
> +
> +		if (lrck_inv)
> +			val |= PCM_INTF_CON1_SYNC_IN_INV;
> +		if (bck_inv)
> +			val |= PCM_INTF_CON1_BCLK_IN_INV;
> +
> +		// TODO: add asrc setting

/* TODO ... */

after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>