[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <o363vir3dqz2znrnifo6enbdwudalmxqbigdkci2ykxf5qjbnx@2ngllflxotgk>
Date: Mon, 20 May 2024 14:00:40 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Vignesh Raman <vignesh.raman@...labora.com>
Cc: dri-devel@...ts.freedesktop.org, daniels@...labora.com,
helen.koike@...labora.com, airlied@...il.com, daniel@...ll.ch, robdclark@...il.com,
david.heidelberg@...labora.com, guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
mcanal@...lia.com, linux-mediatek@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
amd-gfx@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] drm/ci: generate testlist from build
On Fri, May 17, 2024 at 02:54:58PM +0530, Vignesh Raman wrote:
> Stop vendoring the testlist into the kernel. Instead, use the
> testlist from the IGT build to ensure we do not miss renamed
> or newly added tests.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> ---
>
> v2:
> - Fix testlist generation for arm and arm64 builds.
>
> ---
> drivers/gpu/drm/ci/build-igt.sh | 34 +
> drivers/gpu/drm/ci/igt_runner.sh | 9 +-
> drivers/gpu/drm/ci/testlist.txt | 2761 ------------------------------
> 3 files changed, 39 insertions(+), 2765 deletions(-)
> delete mode 100644 drivers/gpu/drm/ci/testlist.txt
>
> diff --git a/drivers/gpu/drm/ci/build-igt.sh b/drivers/gpu/drm/ci/build-igt.sh
> index 7859554756c4..e62244728613 100644
> --- a/drivers/gpu/drm/ci/build-igt.sh
> +++ b/drivers/gpu/drm/ci/build-igt.sh
[...]
> @@ -26,6 +50,16 @@ meson build $MESON_OPTIONS $EXTRA_MESON_ARGS
> ninja -C build -j${FDO_CI_CONCURRENT:-4} || ninja -C build -j 1
> ninja -C build install
>
> +if [[ "$KERNEL_ARCH" = "arm64" ]]; then
> + export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu
> +elif [[ "$KERNEL_ARCH" = "arm" ]]; then
> + export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib
> +else
> + export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib64
Could you please clarify this part? The arm64 vs arm don't look logical
from my point of view.
The rest LGTM.
> +fi
> +
> +generate_testlist
> +
> mkdir -p artifacts/
> tar -cf artifacts/igt.tar /igt
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists