linux-kernel - Re: [PATCH] media: intel/ipu6: Fix some redundant resources freeing in ipu6_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f622051b-7ccd-e261-a311-2073c293602e@linux.intel.com>
Date: Mon, 20 May 2024 19:54:41 +0800
From: Bingbu Cao <bingbu.cao@...ux.intel.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Bingbu Cao <bingbu.cao@...el.com>, Tianshu Qiu <tian.shu.qiu@...el.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-media@...r.kernel.org
Subject: Re: [PATCH] media: intel/ipu6: Fix some redundant resources freeing
 in ipu6_pci_remove()

Christophe,

Thanks for the patch.

On 5/20/24 5:55 PM, Christophe JAILLET wrote:
> pcim_iomap_regions() and pcim_enable_device() are used in the probe. So
> the corresponding managed resources don't need to be freed explicitly in
> the remove function.
> 
> Remove the incorrect pci_release_regions() and pci_disable_device() calls.
> 
> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only
> ---
>  drivers/media/pci/intel/ipu6/ipu6.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index d2bebd208461..f587f609259d 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -727,9 +727,6 @@ static void ipu6_pci_remove(struct pci_dev *pdev)
>  	pm_runtime_forbid(&pdev->dev);
>  	pm_runtime_get_noresume(&pdev->dev);
>  
> -	pci_release_regions(pdev);
> -	pci_disable_device(pdev);
> -
>  	release_firmware(isp->cpd_fw);
>  
>  	ipu6_mmu_cleanup(psys_mmu);
>

Reviewed-by: Bingbu Cao <bingbu.cao@...el.com>

-- 
Best regards,
Bingbu Cao