linux-kernel - Re: [PATCH] kselftest/alsa: Ensure _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b2a93f0-8521-4915-b63d-d28d1d243481@linuxfoundation.org>
Date: Mon, 20 May 2024 08:23:57 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Shuah Khan <shuah@...nel.org>,
 Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Edward Liaw <edliaw@...gle.com>, John Hubbard <jhubbard@...dia.com>,
 linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kselftest/alsa: Ensure _GNU_SOURCE is defined

On 5/17/24 02:35, Takashi Iwai wrote:
> On Thu, 16 May 2024 17:27:33 +0200,
> Mark Brown wrote:
>>
>> The pcmtest driver tests use the kselftest harness which requires that
>> _GNU_SOURCE is defined but nothing causes it to be defined.  Since the
>> KHDR_INCLUDES Makefile variable has had the required define added let's
>> use that, this should provide some futureproofing.
>>
>> Fixes: daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE")
>> Signed-off-by: Mark Brown <broonie@...nel.org>
> 
> The commit isn't yet in the Linus upstream tree but only in
> linux-next.  I guess it's better to put the fix in the tree (Shuah's?)
> that introduced this change.  So feel free to take my ack:
> 
> Acked-by: Takashi Iwai <tiwai@...e.de>
> 
> 

Thank you. I will take this through my tree.

thanks,
-- Shuah