linux-kernel - RE: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52761043C30530D29C51DAFD8CE92@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Mon, 20 May 2024 03:20:47 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Baolu Lu <baolu.lu@...ux.intel.com>, Jason Gunthorpe <jgg@...pe.ca>, Joerg
 Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
	<robin.murphy@....com>, Jean-Philippe Brucker <jean-philippe@...aro.org>,
	Nicolin Chen <nicolinc@...dia.com>, "Liu, Yi L" <yi.l.liu@...el.com>, "Jacob
 Pan" <jacob.jun.pan@...ux.intel.com>, Joel Granados <j.granados@...sung.com>
CC: "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	"virtualization@...ts.linux-foundation.org"
	<virtualization@...ts.linux-foundation.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 3/9] iommu: Add attachment handle to struct iopf_group

> From: Baolu Lu <baolu.lu@...ux.intel.com>
> Sent: Sunday, May 19, 2024 10:04 PM
> 
> On 2024/5/15 15:31, Tian, Kevin wrote:
> >> From: Lu Baolu <baolu.lu@...ux.intel.com>
> >> Sent: Tuesday, April 30, 2024 10:57 PM
> >>
> >> +	handle = iommu_attach_handle_get(dev->iommu_group, pasid, 0);
> >> +	if (IS_ERR(handle))
> >> +		return PTR_ERR(handle);
> >>
> >> -	if (!domain || !domain->iopf_handler) {
> >> -		dev_warn_ratelimited(dev,
> >> -			"iopf (pasid %d) without domain attached or handler
> >> installed\n",
> >> -			 fault->prm.pasid);
> >> +	group->attach_handle = handle;
> >> +	group->domain = handle->domain;
> >
> > this change also removes the warning message. Is it desired?
> 
> Not desired.
> 
> Perhaps we can add a message when the iopf handling is aborted.
> Something like below:
> 
> err_abort:
> +        dev_warn_ratelimited(dev, "iopf with pasid %d aborted\n",
> +                             fault->prm.pasid);
>          iopf_group_response(group, IOMMU_PAGE_RESP_FAILURE);
> 
> Though I am not sure which is better dev_warn() or dev_info().
> 

yes this works. dev_warn() is fine as long as we don't expect it to
happen in sane cases.