linux-kernel - Re: [PATCH workqueue/for-6.10-fixes] workqueue: Refactor worker ID formatting and make wq_worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8r004s1r-06r2-1pq1-4s29-6177np23q0rq@vanv.qr>
Date: Tue, 21 May 2024 01:26:28 +0200 (CEST)
From: Jan Engelhardt <jengelh@...i.de>
To: Tejun Heo <tj@...nel.org>
cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
    Craig Small <csmall@....com.au>, Yafang Shao <laoar.shao@...il.com>, 
    linux-kernel@...r.kernel.org, Lai Jiangshan <jiangshanlai@...il.com>
Subject: Re: [PATCH workqueue/for-6.10-fixes] workqueue: Refactor worker ID
 formatting and make wq_worker_comm() use full ID string


On Tuesday 2024-05-21 00:30, Tejun Heo wrote:

>Currently, worker ID formatting is open coded in create_worker(),
>init_rescuer() and worker_thread() (for %WORKER_DIE case). The formatted ID
>is saved into task->comm and wq_worker_comm() uses it as the base name to
>append extra information to when generating the name to be shown as.
>
>However, TASK_COMM_LEN is only 16 leading to badly truncated names for
>rescuers. For example, the rescuer for the inet_frag_wq workqueue becomes:
>
>  $ ps -ef | grep '[k]worker/R-inet'
>  root         483       2  0 Apr26 ?        00:00:00 [kworker/R-inet_]
>[...]

This patch works satisfactorily for me.


Tested-by: Jan Engelhardt <jengelh@...i.de>