linux-kernel - Re: [PATCH v2 4/6] KEYS: trusted: Move tpm2_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 21 May 2024 22:44:14 +0100
From: David Howells <dhowells@...hat.com>
To: "Jarkko Sakkinen" <jarkko@...nel.org>
Cc: dhowells@...hat.com,
    "James Bottomley" <James.Bottomley@...senPartnership.com>,
    "Herbert Xu" <herbert@...dor.apana.org.au>,
    linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
    Andreas.Fuchs@...ineon.com, "James Prestwood" <prestwoj@...il.com>,
    "David
 Woodhouse" <dwmw2@...radead.org>,
    "Eric Biggers" <ebiggers@...nel.org>,
    "David S. Miller" <davem@...emloft.net>,
    "open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
    "open list" <linux-kernel@...r.kernel.org>,
    "Peter Huewe" <peterhuewe@....de>, "Jason Gunthorpe" <jgg@...pe.ca>,
    "Mimi
 Zohar" <zohar@...ux.ibm.com>,
    "Paul
 Moore" <paul@...l-moore.com>,
    "James Morris" <jmorris@...ei.org>,
    "Serge E.
 Hallyn" <serge@...lyn.com>,
    "open list:SECURITY SUBSYSTEM" <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] KEYS: trusted: Move tpm2_key_decode() to the TPM driver

Jarkko Sakkinen <jarkko@...nel.org> wrote:

> On Tue May 21, 2024 at 9:18 PM EEST, James Bottomley wrote:
> ...
> You don't save a single byte of memory with any constant that dictates
> the size requirements for multiple modules in two disjoint subsystems.

I think James is just suggesting you replace your limit argument with a
constant not that you always allocate that amount of memory.  What the limit
should be, OTOH, is up for discussion, but PAGE_SIZE seems not unreasonable.

David