linux-kernel - [PATCH v2 19/31] Staging: rtl8192e: Remove variable ChkLength

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 20 May 2024 20:17:06 -0700
From: Tree Davies <tdavies@...kphysics.net>
To: gregkh@...uxfoundation.org,
	philipp.g.hortmann@...il.com
Cc: dan.carpenter@...aro.org,
	linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Tree Davies <tdavies@...kphysics.net>
Subject: [PATCH v2 19/31] Staging: rtl8192e: Remove variable ChkLength

Remove variable ChkLength which fixes warning Avoid CamelCase,
and use llc_offset in its place.

Signed-off-by: Tree Davies <tdavies@...kphysics.net>
---
v2: Delete ChkLength, and use llc_offset instead.
 drivers/staging/rtl8192e/rtllib_rx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 52fbbbaf30b0..3a637731506c 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -729,7 +729,6 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 	u16		fc = le16_to_cpu(hdr->frame_control);
 
 	u16		llc_offset = sizeof(struct ieee80211_hdr_3addr);
-	u16		ChkLength;
 	bool		is_aggregate_frame = false;
 	u16		nSubframe_Length;
 	u8		pad_len = 0;
@@ -746,9 +745,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 	if (rx_stats->contain_htc)
 		llc_offset += sHTCLng;
 
-	ChkLength = llc_offset;
-
-	if (skb->len <= ChkLength)
+	if (skb->len <= llc_offset)
 		return 0;
 
 	skb_pull(skb, llc_offset);
-- 
2.30.2