linux-kernel - Re: [PATCH] loadpin: Prevent SECURITY_LOADPIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 21 May 2024 00:14:08 -0400
From: Stephen Boyd <swboyd@...omium.org>
To: Kees Cook <keescook@...omium.org>
Cc: Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>, 
	"Serge E . Hallyn" <serge@...lyn.com>, linux-kernel@...r.kernel.org, patches@...ts.linux.dev, 
	linux-security-module@...r.kernel.org, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH] loadpin: Prevent SECURITY_LOADPIN_ENFORCE=y without
 module decompression

Quoting Kees Cook (2024-05-18 13:47:14)
> On Tue, May 14, 2024 at 03:48:38PM -0700, Stephen Boyd wrote:
> > If modules are built compressed, and LoadPin is enforcing by default, we
> > must have in-kernel module decompression enabled (MODULE_DECOMPRESS).
> > Modules will fail to load without decompression built into the kernel
> > because they'll be blocked by LoadPin. Add a depends on clause to
> > prevent this combination.
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> > ---
> >  security/loadpin/Kconfig | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/security/loadpin/Kconfig b/security/loadpin/Kconfig
> > index 6724eaba3d36..8c22171088a7 100644
> > --- a/security/loadpin/Kconfig
> > +++ b/security/loadpin/Kconfig
> > @@ -14,6 +14,9 @@ config SECURITY_LOADPIN
> >  config SECURITY_LOADPIN_ENFORCE
> >       bool "Enforce LoadPin at boot"
> >       depends on SECURITY_LOADPIN
> > +     # Module compression breaks LoadPin unless modules are decompressed in
> > +     # the kernel.
> > +     depends on MODULE_COMPRESS_NONE || MODULE_DECOMPRESS
> >       help
> >         If selected, LoadPin will enforce pinning at boot. If not
> >         selected, it can be enabled at boot with the kernel parameter
> >
>
> I've folded this change in, since loadpin also works in non-module
> situations:

Thanks for fixing my thinko.