linux-kernel - Re: [PATCH 02/13] regmap: add A2B support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hpid3fdj3igswrqtwavudhgicsadnacbyxbg65to5yr4hduzst@yjspwxnwsw6c>
Date: Tue, 21 May 2024 06:27:19 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Mark Brown <broonie@...nel.org>
CC: Alvin Šipraga <alvin@...s.dk>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Michael
 Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Andi
 Shyti <andi.shyti@...nel.org>, Saravana Kannan <saravanak@...gle.com>, Emil
 Abildgaard Svendsen <EMAS@...g-olufsen.dk>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>
Subject: Re: [PATCH 02/13] regmap: add A2B support

On Fri, May 17, 2024 at 03:42:31PM GMT, Mark Brown wrote:
> On Fri, May 17, 2024 at 02:58:00PM +0200, Alvin Šipraga wrote:
> 
> > +static int regmap_a2b_write(void *context, const void *data, size_t count)
> > +{
> 
> > +	for (i = 0; i < count - 1; i++) {
> > +		ret = bus->ops->write(bus, node, reg + i, d[i + 1]);
> > +		if (ret)
> > +			return ret;
> > +	}
> 
> Just force single_read and single_write

Ah OK, i.e. return -EINVAL if (!config->use_single_read ||
!config->use_single_write) in the init functions below?

> (looks like you'll need to add
> the hook for the bus there).

I am not sure what you mean by this, can you elaborate?

> 
> > +struct regmap *__devm_regmap_init_a2b_node(struct a2b_node *node,
> > +					   const struct regmap_config *config,
> > +					   struct lock_class_key *lock_key,
> > +					   const char *lock_name)
> > +{
> > +	return __devm_regmap_init(&node->dev, &regmap_a2b, node, config,
> > +				  lock_key, lock_name);
> > +}
> > +EXPORT_SYMBOL_GPL(__devm_regmap_init_a2b_node);
> 
> Should there be validation of val_bits?

Yes, I can and should enforce reg/val bits to always be 8.