linux-kernel - Re: [PATCH v2 1/1] PCI : Refactoring error log prints for better readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 21 May 2024 12:12:46 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Onkarnarth <onkarnath.1@...sung.com>
CC: <bhelgaas@...gle.com>, <helgaas@...nel.org>, <vigneshr@...com>,
        <s-vadapalli@...com>, <lpieralisi@...nel.org>, <kw@...ux.com>,
        <robh@...nel.org>, <yue.wang@...ogic.com>, <neil.armstrong@...aro.org>,
        <khilman@...libre.com>, <jbrunet@...libre.com>,
        <martin.blumenstingl@...glemail.com>, <thomas.petazzoni@...tlin.com>,
        <shawn.guo@...aro.org>, <lchuanhua@...linear.com>,
        <srikanth.thokala@...el.com>, <songxiaowei@...ilicon.com>,
        <wangbinghui@...ilicon.com>, <manivannan.sadhasivam@...aro.org>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <hayashi.kunihiko@...ionext.com>, <mhiramat@...nel.org>,
        <pali@...nel.org>, <toan@...amperecomputing.com>,
        <daire.mcnamara@...rochip.com>, <conor.dooley@...rochip.com>,
        <marek.vasut+renesas@...il.com>, <shawn.lin@...k-chips.com>,
        <heiko@...ech.de>, <nirmal.patel@...ux.intel.com>,
        <jonathan.derrick@...ux.dev>, <kishon@...nel.org>, <jdmason@...zu.us>,
        <dave.jiang@...el.com>, <rafael@...nel.org>, <lenb@...nel.org>,
        <mahesh@...ux.ibm.com>, <oohall@...il.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <r.thapliyal@...sung.com>,
        Maninder Singh <maninder1.s@...sung.com>
Subject: Re: [PATCH v2 1/1] PCI : Refactoring error log prints for better
 readability

On Tue, May 21, 2024 at 11:45:28AM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@...sung.com>

nitpick: In $subject:
s/Refactoring/Refactor
to follow the convention of using imperative mood.

> 
> As %pe is already introduced, it's better to use it in place of (%ld) or
> (%d) for printing error in logs. It will enhance readability of logs.
> 
> Error print style is more consistent now.
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Co-developed-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Onkarnath <onkarnath.1@...sung.com>

Thank you for the patch. LGTM.

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

> ---
> Suggested by Bjorn Helgaas in below discussion
> https://patchwork.kernel.org/comment/25712288/
> 
> v1 -> v2: Added suggested by tag
> 
>  drivers/pci/bus.c                             |   2 +-
>  drivers/pci/controller/dwc/pci-dra7xx.c       |   2 +-
>  drivers/pci/controller/dwc/pci-meson.c        |  16 +--
>  drivers/pci/controller/dwc/pcie-armada8k.c    |   4 +-
>  drivers/pci/controller/dwc/pcie-histb.c       |   6 +-
>  drivers/pci/controller/dwc/pcie-intel-gw.c    |  10 +-
>  drivers/pci/controller/dwc/pcie-keembay.c     |   2 +-
>  drivers/pci/controller/dwc/pcie-kirin.c       |   6 +-
>  drivers/pci/controller/dwc/pcie-qcom-ep.c     |  18 +--
>  drivers/pci/controller/dwc/pcie-qcom.c        |  18 +--
>  drivers/pci/controller/dwc/pcie-tegra194.c    | 132 +++++++++---------
>  drivers/pci/controller/dwc/pcie-uniphier-ep.c |   2 +-
>  drivers/pci/controller/pci-aardvark.c         |   6 +-
>  drivers/pci/controller/pci-ftpci100.c         |   2 +-
>  drivers/pci/controller/pci-tegra.c            |  86 ++++++------
>  drivers/pci/controller/pci-xgene.c            |   4 +-
>  drivers/pci/controller/pcie-microchip-host.c  |   2 +-
>  drivers/pci/controller/pcie-rcar-host.c       |  14 +-
>  drivers/pci/controller/pcie-rockchip.c        |  34 ++---
>  drivers/pci/controller/vmd.c                  |   2 +-
>  drivers/pci/doe.c                             |   4 +-
>  drivers/pci/endpoint/functions/pci-epf-mhi.c  |   8 +-
>  drivers/pci/endpoint/functions/pci-epf-ntb.c  |   2 +-
>  drivers/pci/endpoint/functions/pci-epf-test.c |   4 +-
>  drivers/pci/endpoint/functions/pci-epf-vntb.c |   2 +-
>  drivers/pci/endpoint/pci-ep-cfs.c             |  12 +-
>  drivers/pci/endpoint/pci-epf-core.c           |  16 +--
>  drivers/pci/hotplug/acpiphp_core.c            |   2 +-
>  drivers/pci/hotplug/pciehp_core.c             |   8 +-
>  drivers/pci/hotplug/shpchp_core.c             |   4 +-
>  drivers/pci/of.c                              |   6 +-
>  drivers/pci/pci-driver.c                      |   4 +-
>  drivers/pci/pcie/dpc.c                        |   4 +-
>  drivers/pci/quirks.c                          |   2 +-
>  drivers/pci/setup-bus.c                       |   2 +-
>  drivers/pci/slot.c                            |   4 +-
>  drivers/pci/vgaarb.c                          |   2 +-
>  37 files changed, 227 insertions(+), 227 deletions(-)
> 

[...]

Regards,
Siddharth.