linux-kernel - Re: [PATCH 11/13] dt-bindings: a2b: add compatible string for Beosound Shape node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 21 May 2024 09:32:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alvin Šipraga <ALSI@...g-olufsen.dk>
Cc: Alvin Šipraga <alvin@...s.dk>,
 Mark Brown <broonie@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Liam Girdwood <lgirdwood@...il.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Saravana Kannan <saravanak@...gle.com>,
 Emil Abildgaard Svendsen <EMAS@...g-olufsen.dk>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
 "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: Re: [PATCH 11/13] dt-bindings: a2b: add compatible string for
 Beosound Shape node

On 21/05/2024 09:12, Alvin Šipraga wrote:
> On Sun, May 19, 2024 at 01:41:48PM GMT, Krzysztof Kozlowski wrote:
>> On 17/05/2024 15:02, Alvin Šipraga wrote:
>>> From: Alvin Šipraga <alsi@...g-olufsen.dk>
>>>
>>> The Beosound Shape has the same device tree bindings as an AD2425, so it
>>> is sufficient to just add an entry to the compatible enum.
>>
>> ? If it has the same, then devices are compatible but your binding did
>> not express it.
> 
> OK, you're basically saying I should add it all in one patch?

No, I said that your commit msg suggests they are compatible. I don't
fully understand what you wanted to say by "same device tree bindings".

But anyway, make it one patch.

Best regards,
Krzysztof