[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240521010352.1082164-1-nichen@iscas.ac.cn>
Date: Tue, 21 May 2024 09:03:52 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: g@...vu,
perex@...ex.cz,
tiwai@...e.com
Cc: alsa-devel@...a-project.org,
linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org,
Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH] ALSA: scarlett2: Prevent leaking urb
In scarlett2_init_notify() if kmalloc() fails the allocated urb should
be released.
Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
sound/usb/mixer_scarlett2.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_scarlett2.c b/sound/usb/mixer_scarlett2.c
index 1150cf104985..4cad6b2a0292 100644
--- a/sound/usb/mixer_scarlett2.c
+++ b/sound/usb/mixer_scarlett2.c
@@ -8637,9 +8637,10 @@ static int scarlett2_init_notify(struct usb_mixer_interface *mixer)
return -ENOMEM;
transfer_buffer = kmalloc(private->wMaxPacketSize, GFP_KERNEL);
- if (!transfer_buffer)
+ if (!transfer_buffer) {
+ usb_free_urb(mixer->urb);
return -ENOMEM;
-
+ }
usb_fill_int_urb(mixer->urb, dev, pipe,
transfer_buffer, private->wMaxPacketSize,
scarlett2_notify, mixer, private->bInterval);
--
2.25.1
Powered by blists - more mailing lists