linux-kernel - Re: [PATCH] USB: pci-quirks: Skip usb_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024052134-roundness-foyer-7bfa@gregkh>
Date: Tue, 21 May 2024 10:05:36 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Akash Kumar <quic_akakum@...cinc.com>
Cc: Jing Leng <jleng@...arella.com>, Felipe Balbi <balbi@...nel.org>,
	Pratham Pratap  <quic_ppratap@...cinc.com>,
	Jack Pham <quic_jackp@...cinc.com>, kernel@...cinc.com,
	Wesley Cheng <quic_wcheng@...cinc.com>,
	Vijayavardhan Vennapusa <quic_vvreddy@...cinc.com>,
	Krishna Kurapati <quic_kriskura@...cinc.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: pci-quirks: Skip usb_early_handoff for Renesas PCI
 USB

On Tue, May 21, 2024 at 01:16:35PM +0530, Akash Kumar wrote:
> Skip usb_early_handoff for the Renesas PCI USB controller due to
> the firmware not being loaded beforehand, which impacts the bootup
> time.
> 
> Signed-off-by: Akash Kumar <quic_akakum@...cinc.com>

What commit id does this fix?  Should it go to stable kernels?

> ---
>  drivers/usb/host/pci-quirks.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index 0b949acfa258..a0770ecc0861 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -1264,6 +1264,11 @@ static void quirk_usb_early_handoff(struct pci_dev *pdev)
>  		}
>  	}
>  
> +	/* Skip handoff for Renesas PCI USB controller on QCOM SOC */
> +	if ((pdev->vendor == PCI_VENDOR_ID_RENESAS) &&
> +			(pcie_find_root_port(pdev)->vendor == PCI_VENDOR_ID_QCOM))

Why are all Renesas PCI devices on a QCOM host to be marked this way?
That's a very big hammer for potentially lots of devices.  Have you
tested them all?

thanks,

greg k-h