linux-kernel - RE: [PATCH rdma-next 2/3] RDMA/mana_ib: Implement uapi to create and destroy RC QP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR83MB05595340C0BD6AD3BD3789DFB4EA2@PAXPR83MB0559.EURPRD83.prod.outlook.com>
Date: Tue, 21 May 2024 08:48:34 +0000
From: Konstantin Taranov <kotaranov@...rosoft.com>
To: Long Li <longli@...rosoft.com>, Konstantin Taranov
	<kotaranov@...ux.microsoft.com>, "sharmaajay@...rosoft.com"
	<sharmaajay@...rosoft.com>, "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org"
	<leon@...nel.org>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH rdma-next 2/3] RDMA/mana_ib: Implement uapi to create and
 destroy RC QP

> 
> Need to change this comment as RC is supported now.
> 

Thanks, fixed.

> 
> You are adding new UAPI without changing
> MANA_IB_UVERBS_ABI_VERSION.
> 
> For this use-case, I think it's okay because it will fail to create CQ before this.
> But it may not be a good customer experience for RC usage.

ABI versions are for resolving incompatibilities in API, and not for tracking features.
So If a user fails to create an RC QP it means the kernel is old and does not have this feature.
The customer experience is not affected.

Increase in the abi version would invalidate all previous kernels, preventing clients to use the
many versions of kernels and rdma-core together. As a result, breaking the customer experience.

Konstantin