linux-kernel - Re: [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67eef030-7965-4ea6-a390-568c18ae9451@kernel.org>
Date: Tue, 21 May 2024 11:04:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xiaxi Shen <shenxiaxi26@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
 javier.carrasco.cruz@...il.com, skhan@...uxfoundation.org
Cc: lgirdwood@...il.com, broonie@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org
Subject: Re: [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema

On 11/05/2024 23:47, Xiaxi Shen wrote:
> Convert adi,ssm2305 binding to DT schema
> 
> It passed dt_binding_check and dtbs_check. Let me know
> if you think it should include something else

That's not really related to the commit.

> 
> Signed-off-by: Xiaxi Shen <shenxiaxi26@...il.com>
> ---
>  .../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
>  .../bindings/sound/adi,ssm2305.yaml           | 35 +++++++++++++++++++


Same comment as usual... there are no DTS users. Are we done with arm64
defconfig and arm multi_v7 undocumented compatibles? I doubt, 2 months
ago there were hundreds of them. Why touching something without users?

I was speaking about this *multiple times*. Can you update your GSoC or
mentorship guidelines to include this information?


>  2 files changed, 35 insertions(+), 14 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
> 

..


> +maintainers:
> +  - Liam Girdwood <lgirdwood@...il.com>
> +  - Mark Brown <broonie@...nel.org>
> +  - Rob Herring <robh@...nel.org>
> +  - Krzysztof Kozlowski <krzk+dt@...nel.org>
> +  - Conor Dooley <conor+dt@...nel.org>

Not really, this should be someone responsible for the device. No
maintainers or recent, main contributors?

> +
> +properties:
> +  compatible:
> +    const: adi,ssm2305
> +
> +  shutdown-gpios:
> +    maxItems: 1
> +    description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
> +
> +required:
> +  - compatible
> +  - shutdown-gpios> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +   analog-amplifier {
> +     compatible = "adi,ssm2305";
> +     shutdown-gpios = <&gpio3 20 0>;

Use proper define for the flag.

> +   };

Best regards,
Krzysztof