linux-kernel - Re: [PATCH] scsi: mpt3sas: Use a unified annotation style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a61b25e-02e7-4b8d-ab75-17e6f6a6d81a@wdc.com>
Date: Tue, 21 May 2024 11:35:59 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Deming Wang <wangdeming@...pur.com>, "jejb@...ux.ibm.com"
	<jejb@...ux.ibm.com>, "martin.petersen@...al.com" <martin.petersen@...al.com>
CC: "MPT-FusionLinux.pdl@...adcom.com" <MPT-FusionLinux.pdl@...adcom.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: mpt3sas: Use a unified annotation style

On 20.05.24 13:06, Deming Wang wrote:
> Use a unified annotation style.
> 
> Signed-off-by: Deming Wang <wangdeming@...pur.com>
> ---
>   drivers/scsi/mpt3sas/mpt3sas_scsih.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 12d08d8ba538..97062b440e9d 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -2681,8 +2681,8 @@ scsih_device_configure(struct scsi_device *sdev, struct queue_limits *lim)
>   		spin_unlock_irqrestore(&ioc->pcie_device_lock, flags);
>   		mpt3sas_scsih_change_queue_depth(sdev, qdepth);
>   		/* Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
> -		 ** merged and can eliminate holes created during merging
> -		 ** operation.
> +		 * merged and can eliminate holes created during merging
> +		 * operation.
>   		 **/
>   		blk_queue_flag_set(QUEUE_FLAG_NOMERGES,
>   				sdev->request_queue);

This still isn't the recommended kernel comment style.

/*
  * Enable QUEUE_FLAG_NOMERGES flag, so that IOs won't be
  * merged and can eliminate holes created during merging
  * operation.
  */