linux-kernel - Re: [PATCH v6 4/8] drivers: mtd: nand: Add qpic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240521145140.5cb49946@xps-13>
Date: Tue, 21 May 2024 14:51:40 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Md Sadre Alam <quic_mdalam@...cinc.com>
Cc: broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
 richard@....at, vigneshr@...com, manivannan.sadhasivam@...aro.org,
 linux-arm-msm@...r.kernel.org, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mtd@...ts.infradead.org, quic_srichara@...cinc.com,
 quic_varada@...cinc.com
Subject: Re: [PATCH v6 4/8] drivers: mtd: nand: Add qpic_common API file

Hi,

>  drivers/mtd/nand/Makefile            |    4 +-
>  drivers/mtd/nand/qpic_common.c       |  740 +++++++++++++++++
>  drivers/mtd/nand/raw/qcom_nandc.c    | 1090 +-------------------------
>  include/linux/mtd/nand-qpic-common.h |  467 +++++++++++
>  4 files changed, 1222 insertions(+), 1079 deletions(-)
>  create mode 100644 drivers/mtd/nand/qpic_common.c
>  create mode 100644 include/linux/mtd/nand-qpic-common.h
> 
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 19e1291ac4d5..e59106e0a3af 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -3,7 +3,9 @@
>  nandcore-objs := core.o bbt.o
>  obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o
>  obj-$(CONFIG_MTD_NAND_ECC_MEDIATEK) += ecc-mtk.o
> -
> +ifeq ($(CONFIG_MTD_NAND_QCOM),y)
> +obj-y	+= qpic_common.o
> +endif

Breaks if you set CONFIG_MTD_NAND_QCOM = m

>  obj-y	+= onenand/
>  obj-y	+= raw/
>  obj-y	+= spi/
> diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
> new file mode 100644
> index 000000000000..dfbbb5f626b6
> --- /dev/null
> +++ b/drivers/mtd/nand/qpic_common.c
> @@ -0,0 +1,740 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> + */
> +#include <linux/bitops.h>
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/dmaengine.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/dma/qcom_adm.h>
> +#include <linux/dma/qcom_bam_dma.h>
> +#include <linux/module.h>
> +#include <linux/mtd/partitions.h>

Didn't you say you would remove that include?

Thanks,
Miquèl