linux-kernel - Re: [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern matches whole string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ba9113b-7360-4201-b983-e53e90f2be06@foss.st.com>
Date: Tue, 21 May 2024 15:12:49 +0200
From: Olivier MOYSAN <olivier.moysan@...s.st.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
        Arnaud Pouliquen
	<arnaud.pouliquen@...s.st.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark
 Brown <broonie@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>
CC: <alsa-devel@...a-project.org>, <linux-sound@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: stm32: Ensure compatible pattern
 matches whole string

On 5/21/24 00:27, Rob Herring (Arm) wrote:
> The compatible pattern "st,stm32-sai-sub-[ab]" is missing starting and
> ending anchors, so any prefix and/or suffix would still be valid.
> 
> This also fixes a warning on the example:
> 
> Documentation/devicetree/bindings/sound/st,stm32-sai.example.dtb: /example-0/sai@...0b000/audio-controller@...0b004: failed to match any schema with compatible: ['st,stm32-sai-sub-a']
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>   Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> index 59df8a832310..f555ccd6b00a 100644
> --- a/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.yaml
> @@ -68,7 +68,7 @@ patternProperties:
>       properties:
>         compatible:
>           description: Compatible for SAI sub-block A or B.
> -        pattern: "st,stm32-sai-sub-[ab]"
> +        pattern: "^st,stm32-sai-sub-[ab]$"
>   
>         "#sound-dai-cells":
>           const: 0

Reviewed-by: Olivier Moysan <olivier.moysan@...s.st.com>

Thanks
Olivier