linux-kernel - Re: [PATCH v3 7/9] riscv: Enable memory hotplugging for RISC-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHVXubjQr1xzKcjRgB8zA3opj6N93PGpF2=5yKkKK6R07Rpntg@mail.gmail.com>
Date: Tue, 21 May 2024 15:23:47 +0200
From: Alexandre Ghiti <alexghiti@...osinc.com>
To: Björn Töpel <bjorn@...nel.org>
Cc: Albert Ou <aou@...s.berkeley.edu>, David Hildenbrand <david@...hat.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	linux-riscv@...ts.infradead.org, Oscar Salvador <osalvador@...e.de>, 
	Björn Töpel <bjorn@...osinc.com>, 
	Andrew Bresticker <abrestic@...osinc.com>, 
	Chethan Seshadri <Chethan.Seshadri@...alinasystems.io>, Lorenzo Stoakes <lstoakes@...il.com>, 
	Santosh Mamila <santosh.mamila@...alinasystems.io>, 
	Sivakumar Munnangi <siva.munnangi@...alinasystems.io>, Sunil V L <sunilvl@...tanamicro.com>, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v3 7/9] riscv: Enable memory hotplugging for RISC-V

On Tue, May 21, 2024 at 1:49 PM Björn Töpel <bjorn@...nelorg> wrote:
>
> From: Björn Töpel <bjorn@...osinc.com>
>
> Enable ARCH_ENABLE_MEMORY_HOTPLUG and ARCH_ENABLE_MEMORY_HOTREMOVE for
> RISC-V.
>
> Signed-off-by: Björn Töpel <bjorn@...osinc.com>
> ---
>  arch/riscv/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index fe5281398543..2724dc2af29f 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -16,6 +16,8 @@ config RISCV
>         select ACPI_REDUCED_HARDWARE_ONLY if ACPI
>         select ARCH_DMA_DEFAULT_COHERENT
>         select ARCH_ENABLE_HUGEPAGE_MIGRATION if HUGETLB_PAGE && MIGRATION
> +       select ARCH_ENABLE_MEMORY_HOTPLUG if SPARSEMEM_VMEMMAP && 64BIT && MMU

Not sure you need 64BIT && MMU here since ARCH_SPARSEMEM_ENABLE
depends on MMU and SPARSEMEM_VMEMMAP_ENABLE is only enabled on 64BIT.

> +       select ARCH_ENABLE_MEMORY_HOTREMOVE if MEMORY_HOTPLUG
>         select ARCH_ENABLE_SPLIT_PMD_PTLOCK if PGTABLE_LEVELS > 2
>         select ARCH_ENABLE_THP_MIGRATION if TRANSPARENT_HUGEPAGE
>         select ARCH_HAS_BINFMT_FLAT
> --
> 2.40.1
>

But anyway, to me that does not require a new version so you can add:

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex