linux-kernel - Re: [RFC PATCH] usb: typec: ucsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZkynJGchSsg8YQH7@kuha.fi.intel.com>
Date: Tue, 21 May 2024 16:52:36 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>
Cc: gregkh@...uxfoundation.org, lk@...e.de, u.kleine-koenig@...gutronix.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] usb: typec: ucsi_acpi: Add LG Gram quirk

On Thu, May 09, 2024 at 04:27:41PM +0100, Diogo Ivo wrote:
> On Thu, May 09, 2024 at 12:50:36PM GMT, Diogo Ivo wrote:
> > Some LG Gram laptops report a bogus connector change event after a
> > GET_PDOS command for the partner's source PDOs, which disappears from
> > the CCI after acknowledging the command. However, the subsequent
> > GET_CONNECTOR_STATUS in ucsi_handle_connector_change() still reports
> > this bogus change in bits 5 and 6, leading to the UCSI core re-checking
> > the partner's source PDOs and thus to an infinite loop.
> > 
> > Fix this by adding a quirk that signals when a potentially buggy GET_PDOS
> > command is used, checks the status change report and clears it if it is a
> > bogus event before sending it to the UCSI core.
> > 
> > [Sending as RFC both to see if this is a good idea and so that more
> > users can test it to gather all the models affected by this bug.]
> > 
> > Signed-off-by: Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>
> > ---
> 
> I just realized that I should be using the {set, test, clear}_bit()
> functions in the patch I sent, sorry for that. With this in mind it
> would still be good to hear what you think about it.

The quirk looks reasonable to me.

thanks,

-- 
heikki