linux-kernel - Re: [PATCH v2] cxl/region: Fix memregion leaks in devm_cxl_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <664cc9aa97558_e8be2941e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Date: Tue, 21 May 2024 09:19:54 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Li Zhijian <lizhijian@...itsu.com>, <dave@...olabs.net>,
	<jonathan.cameron@...wei.com>, <dave.jiang@...el.com>,
	<alison.schofield@...el.com>, <vishal.l.verma@...el.com>,
	<ira.weiny@...el.com>, <dan.j.williams@...el.com>,
	<linux-cxl@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, Li Zhijian <lizhijian@...itsu.com>
Subject: Re: [PATCH v2] cxl/region: Fix memregion leaks in
 devm_cxl_add_region()

Li Zhijian wrote:
> Move the mode verification to __create_region() before allocating the
> memregion to avoid the memregion leaks.
> 
> Fixes: 6e099264185d ("cxl/region: Add volatile region creation support")
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> ---
> V2: Move the mode verification to __create_region() # Dan
> ---
>  drivers/cxl/core/region.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

LGTM

Reviewed-by: Dan Williams <dan.j.williams@...el.com>