linux-kernel - Re: [PATCH v3 6/6] ACPI: NUMA: replace pr_info with pr_debug in arch_acpi_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zk4tDa0UPL3Xo/0H@sunil-laptop>
Date: Wed, 22 May 2024 23:06:13 +0530
From: Sunil V L <sunilvl@...tanamicro.com>
To: Haibo Xu <haibo1.xu@...el.com>
Cc: arnd@...db.de, xiaobo55x@...il.com, ajones@...tanamicro.com,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
	WANG Xuerui <kernel@...0n.name>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Robert Moore <robert.moore@...el.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	Guo Ren <guoren@...nel.org>, Greentime Hu <greentime.hu@...ive.com>,
	Baoquan He <bhe@...hat.com>, Charlie Jenkins <charlie@...osinc.com>,
	Clément Léger <cleger@...osinc.com>,
	Chen Jiahao <chenjiahao16@...wei.com>,
	Jisheng Zhang <jszhang@...nel.org>,
	James Morse <james.morse@....com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Evan Green <evan@...osinc.com>,
	Samuel Holland <samuel.holland@...ive.com>,
	Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>,
	Tony Luck <tony.luck@...el.com>, Ard Biesheuvel <ardb@...nel.org>,
	Yuntao Wang <ytcoode@...il.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	loongarch@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev
Subject: Re: [PATCH v3 6/6] ACPI: NUMA: replace pr_info with pr_debug in
 arch_acpi_numa_init

On Wed, Apr 24, 2024 at 01:46:26PM +0800, Haibo Xu wrote:
> There are lots of ACPI enabled systems that aren't NUMA and If the
> firmware didn't provide the SRAT/SLIT, then there will be a message
> "Failed to initialise from firmware" from arch_acpi_numa_init() which
> adding noise to the boot on all of those kind of systems. Replace the
> pr_info with pr_debug in arch_acpi_numa_init() to avoid it.
> 
> Suggested-by: Sunil V L <sunilvl@...tanamicro.com>
> Signed-off-by: Haibo Xu <haibo1.xu@...el.com>
> ---
>  drivers/base/arch_numa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c
> index 5b59d133b6af..555aee3ee8e7 100644
> --- a/drivers/base/arch_numa.c
> +++ b/drivers/base/arch_numa.c
> @@ -445,7 +445,7 @@ static int __init arch_acpi_numa_init(void)
>  
>  	ret = acpi_numa_init();
>  	if (ret) {
> -		pr_info("Failed to initialise from firmware\n");
> +		pr_debug("Failed to initialise from firmware\n");
>  		return ret;
>  	}
>  
LGTM. Thanks.

Reviewed-by: Sunil V L <sunilvl@...tanamicro.com>