linux-kernel - Re: [PATCH] spmi: pmic-arb: Pass the correct of_node to irq_domain_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b199a7bb-6d59-43b1-9a7e-000c661b00a5@linaro.org>
Date: Wed, 22 May 2024 19:58:29 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Stephen Boyd <sboyd@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Abel Vesa <abel.vesa@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: Pass the correct of_node to
 irq_domain_add_tree



On 5/22/24 14:06, Dmitry Baryshkov wrote:
> On Wed, 22 May 2024 at 14:38, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>
>> Currently, irqchips for all of the subnodes (which represent a given
>> bus master) point to the parent wrapper node. This is no bueno, as
>> no interrupts arrive, ever (because nothing references that node).
>>
>> Fix that by passing a reference to the respective master's of_node.
>>
>> Worth noting, this is a NOP for devices with only a single master
>> described.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> ---
>>   drivers/spmi/spmi-pmic-arb.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
>> index 791cdc160c51..46ea93f78dcd 100644
>> --- a/drivers/spmi/spmi-pmic-arb.c
>> +++ b/drivers/spmi/spmi-pmic-arb.c
>> @@ -1737,8 +1737,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev,
>>
>>          dev_dbg(&pdev->dev, "adding irq domain for bus %d\n", bus_index);
>>
>> -       bus->domain = irq_domain_add_tree(dev->of_node,
>> -                                         &pmic_arb_irq_domain_ops, bus);
>> +       bus->domain = irq_domain_add_tree(node, pmic_arb_irq_domain_ops, bus);
> 
> Shouldn't it be &pmic_arb_irq_domain_ops ?

Yes. Between testing and editing the patch to un-break the line I managed
to.. break the patch..

Konrad