linux-kernel - Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcbe109d-5974-428d-b74e-c29bec9f68b0@gmail.com>
Date: Wed, 22 May 2024 21:49:41 +0300
From: Péter Ujfalusi <peter.ujfalusi@...il.com>
To: Mithil <bavishimithil@...il.com>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Lopez Cruz <misael.lopez@...com>,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema

Hi,

On 22/05/2024 20:47, Mithil wrote:
> My apologies, misunderstood the error.
> Proposed changes for the next version,
> Add dma, dma-names, reg-names properties, and do the changes in
> example (rename node to mcpdm since it is different from generic pdm).
>   reg-names:
>     items:
>       - const: mpu
>       - const: dma
> 
>   dmas:
>     maxItems: 2
> 
>   dma-names:
>     items:
>       - const: up_link
>       - const: dn_link
> 
> examples:
>     - |
>     #include <dt-bindings/interrupt-controller/arm-gic.h>
>     mcpdm@0 {
>       compatible = "ti,omap4-mcpdm";
>       reg = <0x0 0x7f>, /* MPU private access */
>             <0x49032000 0x7f>; /* L3 Interconnect */
>       reg-names = "mpu", "dma";
>       interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>       interrupt-parent = <&gic>;
>       dmas = <&sdma 65>,
>              <&sdma 66>;
These can be in one line to make it nice and tidy

>       dma-names = "up_link", "dn_link";
>       ti,hwmods = "mcpdm";

The ti,hwmods no longer needed since the sysc conversion

>       clocks = <&twl6040>;
>       clock-names = "pdmclk";
>     };
> 
> Remove ti.hwmods from required since some dts like
> omap4-duovero-parlor, omap4-panda etc do not use it which causes
> dtbs_check to not pass.
> 

-- 
Péter