linux-kernel - Re: [PATCH v2 2/2] cpufreq: amd-pstate: change cpu freq transition delay for some models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202405230325.UPlOikDm-lkp@intel.com>
Date: Thu, 23 May 2024 03:45:08 +0800
From: kernel test robot <lkp@...el.com>
To: Xiaojian Du <Xiaojian.Du@....com>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, tglx@...utronix.de,
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
	hpa@...or.com, daniel.sneddon@...ux.intel.com, jpoimboe@...nel.org,
	pawan.kumar.gupta@...ux.intel.com, sandipan.das@....com,
	kai.huang@...el.com, perry.yuan@....com, x86@...nel.org,
	ray.huang@....com, rafael@...nel.org,
	Xiaojian Du <Xiaojian.Du@....com>,
	Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v2 2/2] cpufreq: amd-pstate: change cpu freq transition
 delay for some models

Hi Xiaojian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/master]
[also build test WARNING on rafael-pm/linux-next rafael-pm/bleeding-edge linus/master next-20240522]
[cannot apply to tip/x86/core tip/auto-latest v6.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xiaojian-Du/cpufreq-amd-pstate-change-cpu-freq-transition-delay-for-some-models/20240522-135241
base:   tip/master
patch link:    https://lore.kernel.org/r/b2c8fb2da41f9fb21f095f67d99cbdbd0aa34091.1716356681.git.Xiaojian.Du%40amd.com
patch subject: [PATCH v2 2/2] cpufreq: amd-pstate: change cpu freq transition delay for some models
config: x86_64-randconfig-006-20240522 (https://download.01.org/0day-ci/archive/20240523/202405230325.UPlOikDm-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240523/202405230325.UPlOikDm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405230325.UPlOikDm-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/cpufreq/amd-pstate.c:824:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
     824 |                 else
         |                 ^
   1 warning generated.


vim +824 drivers/cpufreq/amd-pstate.c

   811	
   812	/*
   813	 * Get pstate transition delay time from ACPI tables that firmware set
   814	 * instead of using hardcode value directly.
   815	 */
   816	static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
   817	{
   818		u32 transition_delay_ns;
   819	
   820		transition_delay_ns = cppc_get_transition_latency(cpu);
   821		if (transition_delay_ns == CPUFREQ_ETERNAL)
   822			if (cpu_feature_enabled(X86_FEATURE_FAST_CPPC))
   823				return AMD_PSTATE_FAST_CPPC_TRANSITION_DELAY;
 > 824			else
   825				return AMD_PSTATE_TRANSITION_DELAY;
   826	
   827		return transition_delay_ns / NSEC_PER_USEC;
   828	}
   829	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki