linux-kernel - Re: [PATCH] Input: ili210x - fix ili251x_read_touch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ed339a9-82cb-403d-92fd-fdcb18653f72@web.de>
Date: Wed, 22 May 2024 22:25:17 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: John Keeping <jkeeping@...usicbrands.com>, linux-input@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] Input: ili210x - fix ili251x_read_touch_data() return
 value

…
> This fixes touch reporting when there are more than 6 active touches.

Does such information indicate a need for the tag “Fixes”?


…
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -255,14 +255,15 @@ static int ili251x_read_reg(struct i2c_client *client,
>  static int ili251x_read_touch_data(struct i2c_client *client, u8 *data)
>  {
>  	int error;
> +	int ret;
>
>  	error = ili251x_read_reg_common(client, REG_TOUCHDATA,
>  					data, ILI251X_DATA_SIZE1, 0);
>  	if (!error && data[0] == 2) {
…

I suggest to define the variable “ret” in the shown if branch.

Regards,
Markus