linux-kernel - Re: [PATCH v18 09/17] x86/resctrl: Add new fields to struct rmid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7569db4a-9237-4158-99d1-775fc0854d59@intel.com>
Date: Wed, 22 May 2024 14:14:53 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
	"Maciej Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v18 09/17] x86/resctrl: Add new fields to struct rmid_read
 for summation of domains

Hi Tony,

On 5/15/2024 3:23 PM, Tony Luck wrote:
> rdtgroup_mondata_show() calls mon_event_count() which packages up all

mon_event_count() -> mon_event_read()?


> the required details into an rmid_read structure passed across the
> smp_call*() infrastructure.
> 
> Legacy files reporting for a single domain pass that domain in the
> rmid_read structure. Files that need to sum multiple domains have
> meta data that provides the display_id for domains that must be
> summed.

( ... and also for convenience pass a domain in the rmid_read structure
 ... more later)

> 
> Add the sumdomains and display_id fields to the rmid_read structure.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 49440f194253..498c5d240c68 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -150,6 +150,8 @@ struct rmid_read {
>  	struct rdt_mon_domain	*d;
>  	enum resctrl_event_id	evtid;
>  	bool			first;
> +	bool			sumdomains;
> +	int			display_id;
>  	int			err;
>  	u64			val;
>  	void			*arch_mon_ctx;

These new members have enough obscurity to make this a good
point to document the members of struct rmid_read

Reinette