linux-kernel - Re: [net PATCH] net: fec: free fec queue when fec_enet_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bbf2c1d-5083-4321-bded-f83aba5428fa@lunn.ch>
Date: Wed, 22 May 2024 05:14:41 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Wei Fang <wei.fang@....com>
Cc: Xiaolei Wang <xiaolei.wang@...driver.com>,
	Shenwei Wang <shenwei.wang@....com>,
	Clark Wang <xiaoning.wang@....com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [net PATCH] net: fec: free fec queue when fec_enet_mii_init()
 fails

> The commit 59d0f7465644 ("net: fec: init multi queue date structure")
> was the first to introduce this issue, commit 619fee9eb13b
> ("net: fec: fix the potential memory leak in fec_enet_init() ")
> fixed this, but it does not seem to be completely fixed.

This fix is also not great, and i would say the initial design is
really the problem. There needs to be a function which is the opposite
of fec_enet_init(). It can then be called in the probe cleanup code,
and in fec_drv_remove() which also appears to leak the queues.

    Andrew