linux-kernel - Re: [PATCH net] net: ti: icssg_prueth: Fix NULL pointer dereference in prueth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 May 2024 11:20:52 +0530
From: MD Danish Anwar <danishanwar@...com>
To: Romain Gantois <romain.gantois@...tlin.com>,
        Roger Quadros
	<rogerq@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH net] net: ti: icssg_prueth: Fix NULL pointer dereference
 in prueth_probe()



On 21/05/24 6:14 pm, Romain Gantois wrote:
> In the prueth_probe() function, if one of the calls to emac_phy_connect()
> fails due to of_phy_connect() returning NULL, then the subsequent call to
> phy_attached_info() will dereference a NULL pointer.
> 
> Check the return code of emac_phy_connect and fail cleanly if there is an
> error.
> 
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>

Reviewed-by: MD Danish Anwar <danishanwar@...com>


-- 
Thanks and Regards,
Danish