linux-kernel - Re: [PATCH v3 1/2] LoongArch: KVM: Add steal time support in kvm side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 22 May 2024 14:15:26 +0800
From: kernel test robot <lkp@...el.com>
To: Bibo Mao <maobibo@...ngson.cn>, Tianrui Zhao <zhaotianrui@...ngson.cn>,
	Huacai Chen <chenhuacai@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Juergen Gross <jgross@...e.com>,
	kvm@...r.kernel.org, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	virtualization@...ts.linux.dev
Subject: Re: [PATCH v3 1/2] LoongArch: KVM: Add steal time support in kvm side

Hi Bibo,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3c999d1ae3c75991902a1a7dad0cb62c2a3008b4]

url:    https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-KVM-Add-steal-time-support-in-kvm-side/20240521-104902
base:   3c999d1ae3c75991902a1a7dad0cb62c2a3008b4
patch link:    https://lore.kernel.org/r/20240521024556.419436-2-maobibo%40loongson.cn
patch subject: [PATCH v3 1/2] LoongArch: KVM: Add steal time support in kvm side
config: loongarch-randconfig-r051-20240522 (https://download.01.org/0day-ci/archive/20240522/202405221317.LCtBJH1F-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240522/202405221317.LCtBJH1F-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405221317.LCtBJH1F-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/loongarch/kvm/exit.c: In function 'kvm_save_notify':
>> arch/loongarch/kvm/exit.c:711:63: error: 'struct sched_info' has no member named 'run_delay'
     711 |                 vcpu->arch.st.last_steal = current->sched_info.run_delay;
         |                                                               ^
--
   arch/loongarch/kvm/vcpu.c: In function 'kvm_update_stolen_time':
>> arch/loongarch/kvm/vcpu.c:67:37: error: 'struct sched_info' has no member named 'run_delay'
      67 |         steal += current->sched_info.run_delay -
         |                                     ^
   arch/loongarch/kvm/vcpu.c:69:55: error: 'struct sched_info' has no member named 'run_delay'
      69 |         vcpu->arch.st.last_steal = current->sched_info.run_delay;
         |                                                       ^
   arch/loongarch/kvm/vcpu.c: In function 'kvm_loongarch_pvtime_set_attr':
   arch/loongarch/kvm/vcpu.c:138:63: error: 'struct sched_info' has no member named 'run_delay'
     138 |                 vcpu->arch.st.last_steal = current->sched_info.run_delay;
         |                                                               ^


vim +711 arch/loongarch/kvm/exit.c

   692	
   693	static long kvm_save_notify(struct kvm_vcpu *vcpu)
   694	{
   695		unsigned long id, data;
   696	
   697		id   = kvm_read_reg(vcpu, LOONGARCH_GPR_A1);
   698		data = kvm_read_reg(vcpu, LOONGARCH_GPR_A2);
   699		switch (id) {
   700		case KVM_FEATURE_STEAL_TIME:
   701			if (!kvm_pvtime_supported())
   702				return KVM_HCALL_INVALID_CODE;
   703	
   704			if (data & ~(KVM_STEAL_PHYS_MASK | KVM_STEAL_PHYS_VALID))
   705				return KVM_HCALL_INVALID_PARAMETER;
   706	
   707			vcpu->arch.st.guest_addr = data;
   708			if (!(data & KVM_STEAL_PHYS_VALID))
   709				break;
   710	
 > 711			vcpu->arch.st.last_steal = current->sched_info.run_delay;
   712			kvm_make_request(KVM_REQ_STEAL_UPDATE, vcpu);
   713			break;
   714		default:
   715			break;
   716		};
   717	
   718		return 0;
   719	};
   720	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki