linux-kernel - Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51ba1fc1-fd77-4601-8d27-459162fd008c@linux.alibaba.com>
Date: Wed, 22 May 2024 17:38:46 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: David Hildenbrand <david@...hat.com>, akpm@...ux-foundation.org
Cc: willy@...radead.org, ying.huang@...el.com, 21cnbao@...il.com,
 ryan.roberts@....com, ziy@...dia.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: drop the 'anon_' prefix for swap-out mTHP counters



On 2024/5/22 16:58, David Hildenbrand wrote:
> On 22.05.24 10:51, Baolin Wang wrote:
>> The mTHP swap related counters: 'anon_swpout' and 
>> 'anon_swpout_fallback' are
>> confusing with an 'anon_' prefix, since the shmem can swap out 
>> non-anonymous
>> pages. So drop the 'anon_' prefix to keep consistent with the old swap 
>> counter
>> names.
>>
>> Suggested-by: "Huang, Ying" <ying.huang@...el.com>
>> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
>> ---
> 
> Am I daydreaming or did we add the anon_ for a reason and discussed the 
> interaction with shmem? At least I remember some discussion around that.

Do you mean the shmem mTHP allocation counters in previous 
discussion[1]? But for 'anon_swpout' and 'anon_swpout_fallback', I can 
not find previous discussions that provided a reason for adding the 
‘anon_’ prefix. Barry, any comments? Thanks.

[1] 
https://lore.kernel.org/all/05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com/