linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: sunxi: Correct the descriptions for Pine64 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 22 May 2024 11:05:07 +0100
From: Andre Przywara <andre.przywara@....com>
To: Dragan Simic <dsimic@...jaro.org>
Cc: Icenowy Zheng <uwu@...nowy.me>, linux-sunxi@...ts.linux.dev,
 wens@...e.org, jernej.skrabec@...il.com, samuel@...lland.org,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 robh+dt@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 linux-kernel@...r.kernel.org, didi.debian@...ow.org, Marek Kraus
 <gamiee@...e64.org>
Subject: Re: [PATCH 1/2] dt-bindings: arm: sunxi: Correct the descriptions
 for Pine64 boards

On Wed, 22 May 2024 08:10:21 +0200
Dragan Simic <dsimic@...jaro.org> wrote:

Hi,

> Hello Icenowy,
> 
> On 2024-05-22 02:48, Icenowy Zheng wrote:
> > 在 2024-04-23星期二的 03:00 +0200，Dragan Simic写道：  
> >> Correct the descriptions of a few Pine64 boards and devices,
> >> according
> >> to their official names used on the Pine64 wiki.  This ensures
> >> consistency
> >> between the officially used names and the names in the source code.
> >> 
> >> Cc: Marek Kraus <gamiee@...e64.org>
> >> Signed-off-by: Dragan Simic <dsimic@...jaro.org>
> >> ---
> >> 
> >> Notes:
> >>     This completes the correction of the descriptions of the Pine64
> >> boards
> >>     and devices, which was started with the Pine64 boards and devices
> >> based
> >>     on Rockchip SoCs. [1]
> >>    
> >>     [1]
> >> https://lore.kernel.org/linux-rockchip/ec124dab2b1a8776aa39177ecce34babca3a50e2.1713832790.git.dsimic@manjaro.org/
> >> 
> >>  Documentation/devicetree/bindings/arm/sunxi.yaml | 12 ++++++------
> >>  1 file changed, 6 insertions(+), 6 deletions(-)
> >> 
> >> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> b/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> index 09d835db6db5..b66873ae2d71 100644
> >> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> >> @@ -709,17 +709,17 @@ properties:
> >>            - const: sochip,s3
> >>            - const: allwinner,sun8i-v3
> >>  
> >> -      - description: Pine64 PineH64 model A
> >> +      - description: Pine64 H64 Model A
> >>          items:
> >>            - const: pine64,pine-h64
> >>            - const: allwinner,sun50i-h6
> >>  
> >> -      - description: Pine64 PineH64 model B
> >> +      - description: Pine64 H64 Model B  
> > 
> > Sorry for replying so late, but I don't think there is a Pine64 H64
> > board. The Pine64 wiki calls it Pine H64. [1]
> > 
> > [1] https://wiki.pine64.org/wiki/PINE_H64  
> 
> Good point, thanks.  Though, this board is really an exception to
> the naming scheme employed for the Pine64 boards, so perhaps it would
> actually be better to rename the board in the Pine64 wiki, by adding
> "64" to "Pine", to ensure consistency.

I am sorry, but I don't think this is how it works. The board is really
called "Pine H64", that's printed on the board [1] and everywhere else [2].
That's a choice the manufacturer made, and renaming some Wiki page won't
change that. I understand the engineer's desire to make everything nice and
consistent ;-) , but I am afraid that's not our call. After all this file
is to document the device naming, not to be an example of consistent
naming schemes.

Cheers,
Andre

[1] https://linux-sunxi.org/images/5/53/Pineh64_top.jpg
[2] https://pine64.org/devices/pine_h64_model_a/
> 
> Alas, the Pine64 wiki is currently in read-only mode, due to some
> recent issues with the underlying hardware that runs it.  Migration to
> another form of documentation for Pine64 boards is also a possibility,
> which makes the updates even more complicated.
> 
> With all this in mind, I think it would be the best to rename the board
> on the Pine64 side, to ensure consistency, and keep this patch as-is.
> I'll make a mental note to do that on the Pine64 side once the current
> situation with the Pine64 wiki is resolved.
> 
> >>          items:
> >>            - const: pine64,pine-h64-model-b
> >>            - const: allwinner,sun50i-h6
> >>  
> >> -      - description: Pine64 LTS
> >> +      - description: Pine64 A64 LTS
> >>          items:
> >>            - const: pine64,pine64-lts
> >>            - const: allwinner,sun50i-r18
> >> @@ -748,17 +748,17 @@ properties:
> >>            - const: pine64,pinephone
> >>            - const: allwinner,sun50i-a64
> >>  
> >> -      - description: Pine64 PineTab, Development Sample
> >> +      - description: Pine64 PineTab Developer Sample
> >>          items:
> >>            - const: pine64,pinetab
> >>            - const: allwinner,sun50i-a64
> >>  
> >> -      - description: Pine64 PineTab, Early Adopter's batch (and
> >> maybe later ones)
> >> +      - description: Pine64 PineTab Early Adopter
> >>          items:
> >>            - const: pine64,pinetab-early-adopter
> >>            - const: allwinner,sun50i-a64
> >>  
> >> -      - description: Pine64 SoPine Baseboard
> >> +      - description: Pine64 SOPine
> >>          items:
> >>            - const: pine64,sopine-baseboard
> >>            - const: pine64,sopine
> >>   
>