linux-kernel - Re: [REPOST PATCH v3] crypto: ecc - Prevent ecc_digits_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zk3EZqQcMYKiDvhC@wunner.de>
Date: Wed, 22 May 2024 12:09:42 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Stefan Berger <stefanb@...ux.ibm.com>
Cc: keyrings@...r.kernel.org, linux-crypto@...r.kernel.org,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	linux-kernel@...r.kernel.org, jarkko@...nel.org
Subject: Re: [REPOST PATCH v3] crypto: ecc - Prevent ecc_digits_from_bytes
 from reading too many bytes

On Tue, May 21, 2024 at 06:50:06PM -0400, Stefan Berger wrote:
> Prevent ecc_digits_from_bytes from reading too many bytes from the input
> byte array in case an insufficient number of bytes is provided to fill the
> output digit array of ndigits. Therefore, initialize the most significant
> digits with 0 to avoid trying to read too many bytes later on. Convert the
> function into a regular function since it is getting too big for an inline
> function.
> 
> If too many bytes are provided on the input byte array the extra bytes
> are ignored since the input variable 'ndigits' limits the number of digits
> that will be filled.
> 
> Fixes: d67c96fb97b5 ("crypto: ecdsa - Convert byte arrays with key coordinates to digits")
> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
> 
> ---
> v3:
>  - Applied Jarkko's tag

Already landed in Linus' tree 42 hours ago -- with Jarkko's tag:

https://git.kernel.org/linus/568c98a0f6ef