linux-kernel - Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 22 May 2024 12:34:21 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, 
	Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, linux-crypto@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64/crypto: Raise priority of NEON crct10dif implementation

On Tue, 21 May 2024 at 22:23, Mark Brown <broonie@...nel.org> wrote:
>
> The NEON implementation of crctd10dif is registered with a priority of 100
> which is identical to that used by the generic C implementation. Raise the
> priority to 150, half way between the PMULL based implementation and the
> NEON one, so that it will be preferred over the generic implementation.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>  arch/arm64/crypto/crct10dif-ce-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/crct10dif-ce-glue.c b/arch/arm64/crypto/crct10dif-ce-glue.c
> index 09eb1456aed4..59016518f44d 100644
> --- a/arch/arm64/crypto/crct10dif-ce-glue.c
> +++ b/arch/arm64/crypto/crct10dif-ce-glue.c
> @@ -98,7 +98,7 @@ static struct shash_alg crc_t10dif_alg[] = {{
>
>         .base.cra_name          = "crct10dif",
>         .base.cra_driver_name   = "crct10dif-arm64-neon",
> -       .base.cra_priority      = 100,
> +       .base.cra_priority      = 150,
>         .base.cra_blocksize     = CRC_T10DIF_BLOCK_SIZE,
>         .base.cra_module        = THIS_MODULE,
>  }, {
>
> ---
> base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
> change-id: 20240521-arm64-crct10dif-neon-prio-894a9350ec1e
>
> Best regards,
> --
> Mark Brown <broonie@...nel.org>
>
>