linux-kernel - Re: [PATCH] drivers: iio: adc: add support for ad777x family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zk4KSlZ7NFgYx2Co@smile.fi.intel.com>
Date: Wed, 22 May 2024 18:07:54 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Nechita, Ramona" <Ramona.Nechita@...log.com>
Cc: Nuno Sá <noname.nuno@...il.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, "Sa, Nuno" <Nuno.Sa@...log.com>,
	Marius Cristea <marius.cristea@...rochip.com>,
	"Schmitt, Marcelo" <Marcelo.Schmitt@...log.com>,
	Maksim Kiselev <bigunclemax@...il.com>,
	Ivan Mikhaylov <fr0st61te@...il.com>,
	Marcus Folkesson <marcus.folkesson@...il.com>,
	Liam Beguin <liambeguin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: iio: adc: add support for ad777x family

On Wed, May 22, 2024 at 03:01:52PM +0000, Nechita, Ramona wrote:
> Hello Nuno,
> 
> I apologize, I accidentally submitted the updated version that I used for the
> project, instead of the one without axi. I will fix it and resend the patch
> asap.

First of all, do not top-post!

Second, don't do ASAP, take your time, read the comments given for this version
and address the same / similar issues in any code you are possessing before
sending.

> -----Original Message-----
> From: Nuno Sá <noname.nuno@...il.com> 
> Sent: Wednesday, May 22, 2024 5:36 PM
> On Wed, 2024-05-22 at 14:59 +0300, ranechita wrote:
> > Added support for ad7770,ad7771,ad7779 ADCs. The data is streamed only 
> > on the spi-mode, without using the data lines.

> Is this even compiling? This is definitely not code to be upstreamed since it
> relies on the our out-of-tree/legacy driver for the adi-axi-adc. You need to
> convert this to use the IIO backend framework (adding new interfaces if
> needed).

-- 
With Best Regards,
Andy Shevchenko