linux-kernel - Re: [PATCH v3 8/8] hwmon: (k10temp) Rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e765d02-c7ef-48db-83b0-341362d71c70@roeck-us.net>
Date: Thu, 23 May 2024 12:32:45 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Yazen Ghannam <yazen.ghannam@....com>, x86@...nel.org
Cc: Mario Limonciello <mario.limonciello@....com>,
 linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v3 8/8] hwmon: (k10temp) Rename _data variable

On 5/23/24 11:26, Yazen Ghannam wrote:
> ...to address the following warning:
> 
> drivers/hwmon/k10temp.c:273:47:
> warning: declaration shadows a variable in the global scope [-Wshadow]
> static umode_t k10temp_is_visible(const void *_data,
>                                                ^
> include/asm-generic/sections.h:36:13:
> note: previous declaration is here
> extern char _data[], _sdata[], _edata[];
> 
> No functional change is intended.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>

Acked-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/hwmon/k10temp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index a2d203304533..543526bac042 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -269,11 +269,11 @@ static int k10temp_read(struct device *dev, enum hwmon_sensor_types type,
>   	}
>   }
>   
> -static umode_t k10temp_is_visible(const void *_data,
> +static umode_t k10temp_is_visible(const void *drvdata,
>   				  enum hwmon_sensor_types type,
>   				  u32 attr, int channel)
>   {
> -	const struct k10temp_data *data = _data;
> +	const struct k10temp_data *data = drvdata;
>   	struct pci_dev *pdev = data->pdev;
>   	u32 reg;
>   
>