linux-kernel - Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240523-rinse-sturdily-7c78d8517884@spud>
Date: Thu, 23 May 2024 20:33:38 +0100
From: Conor Dooley <conor@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Eddie James <eajames@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org,
	linux-aspeed@...ts.ozlabs.org, devicetree@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-spi@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Andi Shyti <andi.shyti@...nel.org>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Lakshmi Yadlapati <lakshmiy@...ibm.com>,
	Mark Brown <broonie@...nel.org>,
	Ninad Palsule <ninad@...ux.ibm.com>, Rob Herring <robh@...nel.org>
Subject: Re: [v6 17/20] ARM: dts: aspeed: Add IBM Huygens BMC system

Markus,

On Thu, May 23, 2024 at 09:30:55PM +0200, Markus Elfring wrote:
> >>> The Huygens is a Rainier with modifed FSI wiring.
> >> Will imperative wordings become helpful for a better commit message here?
> >
> >
> > This statement is a description of hardware. I cannot word that imperatively.
> 
> Please take another look at corresponding improvement possibilities.
> 
> 
> > The commit message is imperative - "Add Huygens system".
> 
> This information fits to the summary phrase.
> 
> Would you like to mention in the changelog that a hardware description
> should be extended anyhow?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94

You are talking absolute crap here. Stop harassing contributors with
your inane comments.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)