linux-kernel - Re: [PATCH] mm/filemap: invalidating pages is still necessary when io with IOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240523130802.730d2790b8e5f691871575c0@linux-foundation.org>
Date: Thu, 23 May 2024 13:08:02 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Liu Wei <liuwei09@...tc.cn>
Cc: willy@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/filemap: invalidating pages is still necessary when
 io with IOCB_NOWAIT

On Mon, 13 May 2024 21:23:39 +0800 Liu Wei <liuwei09@...tc.cn> wrote:

> After commit (6be96d3ad3 fs: return if direct I/O will trigger writeback),
> when we issuing AIO with direct I/O and IOCB_NOWAIT on a block device, the
> process context will not be blocked.
> 
> However, if the device already has page cache in memory, EAGAIN will be
> returned. And even when trying to reissue the AIO with direct I/O and
> IOCB_NOWAIT again, we consistently receive EAGAIN.
> 
> Maybe a better way to deal with it: filemap_fdatawrite_range dirty pages
> with WB_SYNC_NONE flag, and invalidate_mapping_pages unmapped pages at
> the same time.

Can't userspace do this?  If EAGAIN, sync the fd and retry the IO?