linux-kernel - Re: [PATCH 3/4] acpi/ghes, cxl/pci: Trace FW-First CXL Protocol Errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34fe7471-d17e-b802-f9cc-a83ad23ef409@amd.com>
Date: Thu, 23 May 2024 14:35:51 -0700
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
To: Alison Schofield <alison.schofield@...el.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-cxl@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
 Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Yazen Ghannam <yazen.ghannam@....com>, Bowman Terry <terry.bowman@....com>
Subject: Re: [PATCH 3/4] acpi/ghes, cxl/pci: Trace FW-First CXL Protocol
 Errors

On 5/22/2024 5:22 PM, Alison Schofield wrote:
> On Wed, May 22, 2024 at 03:08:38PM +0000, Smita Koralahalli wrote:
>> When PCIe AER is in FW-First, OS should process CXL Protocol errors from
>> CPER records.
>>
>> Reuse the existing work queue cxl_cper_work registered with GHES to notify
>> the CXL subsystem on a Protocol error.
>>
>> The defined trace events cxl_aer_uncorrectable_error and
>> cxl_aer_correctable_error currently trace native CXL AER errors. Reuse
>> them to trace FW-First Protocol Errors.
> 
> Will the trace log differentiate between errors reported in FW-First
> versus Native mode?  Wondering if that bit of info needs to be logged
> or is discoverable elsewhere.

No, the trace log won't differentiate currently.

But just a side note, FW-First also logs errors in dmesg. I'm not sure 
if going forward, we would still continue to log errors in dmesg. But I 
feel it might be needed so that we don't miss errors from RCH Downstream 
Port or hexdump of unrecognized agent types.

Thanks
Smita

> 
> Otherwise, LGTM,
> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
> 
> 
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
>> ---
>>   drivers/acpi/apei/ghes.c  | 14 ++++++++++++++
>>   drivers/cxl/core/pci.c    | 24 ++++++++++++++++++++++++
>>   drivers/cxl/cxlpci.h      |  3 +++
>>   drivers/cxl/pci.c         | 34 ++++++++++++++++++++++++++++++++--
>>   include/linux/cxl-event.h |  1 +
>>   5 files changed, 74 insertions(+), 2 deletions(-)
> 
> snip
> 
>