linux-kernel - Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f19f63ba-c436-4e39-ab86-78c80b1af667@intel.com>
Date: Thu, 23 May 2024 15:48:22 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Peter Xu <peterx@...hat.com>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>, Jason Gunthorpe <jgg@...dia.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Al Viro
 <viro@...iv.linux.org.uk>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Andy Lutomirski <luto@...nel.org>, Matthew Wilcox <willy@...radead.org>,
 Dan Williams <dan.j.williams@...el.com>,
 "Kirill A . Shutemov" <kirill@...temov.name>, Mike Rapoport
 <rppt@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Michal Hocko <mhocko@...e.com>, Alex Williamson
 <alex.williamson@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Borislav Petkov <bp@...en8.de>,
 x86@...nel.org
Subject: Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large
 mappings

On 5/23/24 15:37, Peter Xu wrote:
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 317de2afd371..c4a2356b1a54 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1135,7 +1135,7 @@ static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr,
>  		goto out_unlock;
>  	}
>  
> -	entry = pmd_mkhuge(pfn_t_pmd(pfn, prot));
> +	entry = pmd_mkhuge(pfn_t_pmd(pfn, pgprot_4k_2_large(prot)));
>  	if (pfn_t_devmap(pfn))
>  		entry = pmd_mkdevmap(entry);
>  	if (write) {

Does this even compile on non-x86 architectures?