linux-kernel - Re: DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 08:12:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Daniel Baluta <daniel.baluta@....com>, Shuah Khan
 <skhan@...uxfoundation.org>, Julia Lawall <julia.lawall@...ia.fr>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 Péter Ujfalusi <peter.ujfalusi@...il.com>,
 linux-kernel@...r.kernel.org
Subject: Re: DT schema bindings conversion mentorships (was Re: [PATCH v5]
 ASoC: dt-bindings: omap-mcpdm: Convert to DT schema)

On 22/05/2024 19:47, Javier Carrasco wrote:
>> https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY
>>
>> 1. Please convert bindings which have active DTS users. First choose
>> bindings with DTS built by arm64 defconfig, then next choice by arm
>> multi_v7 defconfig. Then any other ARM or different architecture DTS.
>>
>> 2. Be sure dt_bindings_check (including yamllint) and checkpatch pass
>> without any warnings. See writing-schema.rst document.
>>
>> 3. Be sure DTS using these bindings passes dtbs_check validation. If
>> this means binding needs to be adapted during conversion, mention
>> briefly in the commit message changes done comparing to pure TXT->DT
>> schema conversion.
>>
>> Best regards,
>> Krzysztof
>>
> 
> 
> Hello Krzysztof,
> 
> Several mentees from the Linux Kernel Mentorship Program have been
> converting bindings within the last weeks, but it was not a programmed
> task from the mentorship as such. They are free to choose the areas
> where they want to contribute, and some of them chose that one.
> Therefore no direct contact with the subsystem maintainers was
> established. We will keep an eye on that too, so we can anticipate such
> misunderstandings and additional work for the maintainers.
> 
> Nonetheless, I saw that some our mentees sent such faulty/pointless
> conversions a few days ago, and they received some guidelines and links
> to the official documentation yesterday. All points you mentioned were
> covered, so the next patches should look better.
> 
> Usually their patches are sent to the mentors first for a preliminary
> review, but sometimes that step gets "bypassed". We will insist on the
> preliminary review, at least for the first conversions.
> 
> Apologies for any faulty patch they might still send directly/not taking
> those points into account.
> 
> Thank you so much for your patience and feedback.

Sounds good, thanks Javier!

Best regards,
Krzysztof