lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r0dtattp.fsf@kernel.org>
Date: Thu, 23 May 2024 10:08:50 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: michael.nemanov@...com,  Johannes Berg <johannes.berg@...el.com>,  Breno
 Leitao <leitao@...ian.org>,  Justin Stitt <justinstitt@...gle.com>,  Kees
 Cook <keescook@...omium.org>,  linux-wireless@...r.kernel.org,
  linux-kernel@...r.kernel.org,  Sabeeh Khan <sabeeh-khan@...com>
Subject: Re: [PATCH 13/17] Add conf.h

Krzysztof Kozlowski <krzk@...nel.org> writes:

> On 21/05/2024 19:18, michael.nemanov@...com wrote:
>> From: Michael Nemanov <Michael.Nemanov@...com>
>> 
>> Various HW / FW / Driver controls unique for the CC33xx that
>> can be set by OEMs.
>> 
>> Signed-off-by: Michael Nemanov <michael.nemanov@...com>
>> ---
>>  drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++
>
> So you are adding one file by another? This does not help review.
>
> Add logical chunks, e.g. users of header after the header. Or all
> headers together. Or some features incrementally, like basic working
> driver and then feature foo and bar.

For new wireless drivers my recommendation has been to submit for review
one file per patch but the final driver to be commited would be just one
patch:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ