linux-kernel - Re: [PATCH v2 0/2] workqueue: Fix rescuer task's name truncated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 09:36:57 +0800
From: Wenchao Hao <haowenchao22@...il.com>
To: Wenchao Hao <haowenchao2@...wei.com>, Tejun Heo <tj@...nel.org>,
 Lai Jiangshan <jiangshanlai@...il.com>, Aaron Tomlin <atomlin@...mlin.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] workqueue: Fix rescuer task's name truncated

On 2024/5/13 22:01, Wenchao Hao wrote:
> Task comm of task is limitted to 16, prefix "kworker/R-" is added for
> rescuer worker's task, which cause most task name is truncated as
> following:
> 
> root   81  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-xprti]
> root   82  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-cfg80]
> root   85  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-nfsio]
> root   86  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-xfsal]
> root   87  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-xfs_m]
> root   88  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-acpi_]
> root   93  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-iscsi]
> root   95  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-scsi_]
> root   97  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-scsi_]
> root   99  0.0  0.0  0  0 ?   I<   11:18   0:00 [kworker/R-scsi_]
> 
> I want to fix this issue by split rescuer name to 2 part like other
> kworker, the normal part is "kworker/R" which is set to task_struct's comm,
> another part is wq->name which is added to kworker's desc. These 2 parts
> would be merged in wq_worker_comm().
> 
> The first patch fix the rescuer task's name truncated;
> The second patch fix workqueue_struct's name truncated.
> 

Friendly ping...

> V2:
> Add another patch to increased worker desc's length to 32 to fix compile
> warning reported:
> https://lore.kernel.org/oe-kbuild-all/202405131400.sEYZHYk2-lkp@intel.com/
> 
> Wenchao Hao (2):
>    workqueue: Fix rescuer task's name truncated
>    workqueue: Increase worker desc's length to 32
> 
>   include/linux/workqueue.h | 2 +-
>   kernel/workqueue.c        | 6 +++++-
>   2 files changed, 6 insertions(+), 2 deletions(-)
>