linux-kernel - Re: [PATCH] utsname: constify ctl_table arguments of utility function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 23 May 2024 10:19:08 +0200
From: Joel Granados <j.granados@...sung.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
CC: <linux-kernel@...r.kernel.org>, Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH] utsname: constify ctl_table arguments of utility
 function

On Sat, May 18, 2024 at 03:53:40PM +0200, Thomas Weißschuh wrote:
> The sysctl core is preparing to only expose instances of
...
> 
> Cc: Joel Granados <j.granados@...sung.com>
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> ---
>  kernel/utsname_sysctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/utsname_sysctl.c b/kernel/utsname_sysctl.c
> index 76a772072557..04e4513f2985 100644
> --- a/kernel/utsname_sysctl.c
> +++ b/kernel/utsname_sysctl.c
> @@ -15,7 +15,7 @@
>  
>  #ifdef CONFIG_PROC_SYSCTL
>  
> -static void *get_uts(struct ctl_table *table)
> +static void *get_uts(const struct ctl_table *table)
>  {
>  	char *which = table->data;
>  	struct uts_namespace *uts_ns;
> 
> ---
> base-commit: 4b377b4868ef17b040065bd468668c707d2477a5
> change-id: 20240518-sysctl-const-handler-utsname-3f3eec4e6dc3
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@...ssschuh.net>
> 

LGTM.

I'll bring this in through the sysctl tree for the next release; unless
folks want it to go in another way. For now it will go to sysctl-testing
waiting for the merge window to be closed.

Reviewed-by: Joel Granados <j.granados@...sung.com>

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)